linux-kernel - Re: [PATCH v1] ASoC: Intel: sof_rt5682: Enable Bluetooth offload on adl_rt1019

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6a96b2d-19d2-97fe-387f-cddc4abbb590@linux.intel.com>
Date:   Mon, 13 Mar 2023 09:36:07 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
Cc:     linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Brent Lu <brent.lu@...el.com>,
        Yong Zhi <yong.zhi@...el.com>, dharageswari.r@...el.com,
        Vamshi Krishna <vamshi.krishna.gopal@...el.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        alsa-devel@...a-project.org, Mac Chiang <mac.chiang@...el.com>
Subject: Re: [PATCH v1] ASoC: Intel: sof_rt5682: Enable Bluetooth offload on
 adl_rt1019_rt5682



On 3/10/23 17:55, Ajye Huang wrote:
> On Sat, Mar 11, 2023 at 6:46 AM Pierre-Louis Bossart
> <pierre-louis.bossart@...ux.intel.com> wrote:
>>
> 
>> It's best if you provide a series that enables BT offload across the
>> board for ADL, if that's the intended goal.
> Hi Pierre,
> 
>   {        .name = "adl_mx98357_rt5682",
>         .driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
>                     SOF_RT5682_SSP_CODEC(0) |
>                     SOF_SPEAKER_AMP_PRESENT |
>                     SOF_RT5682_SSP_AMP(2) |
>                     SOF_RT5682_NUM_HDMIDEV(4)),
>     },
> The "adl_mx98357_rt5682" is the sound card of the google "Brya" Board project.
> Because the SSP2 is used for the max98357 amplifier, so SSP2
> bt_offload can't be enabled at the drv_name  "adl_mx98357_rt5682".
> (The hardway layout I2S port2 connected to max98357 amplifier)
> 
> The other adl projects that enabled the bt_offload feature were
> designed with ssp1 for amp, ssp2 for bt_offload based on pins
> definition.
>     {
>         .name = "adl_rt1019_rt5682",
>         .driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
>                     SOF_RT5682_SSP_CODEC(0) |
>                     SOF_SPEAKER_AMP_PRESENT |
>                     SOF_RT1019_SPEAKER_AMP_PRESENT |
>                     SOF_RT5682_SSP_AMP(1) |
>                     SOF_RT5682_NUM_HDMIDEV(4) |
>                     SOF_BT_OFFLOAD_SSP(2) |
>                     SOF_SSP_BT_OFFLOAD_PRESENT),
>     },

ok, so for this patch:

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

I accept the argument that when SSP2 is used for the amplifier then it
can't be used for BT offload, but I still find "mtl_mx98360_rt5682"
missing BT offload.  This would need a follow-up patch or a comment if
this miss was intentional (not formally supported).