linux-kernel - Re: [PATCH v3 2/2] gpio: fxl6408: add I2C GPIO expander driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZA9iPnmgNO7PSv6O@francesco-nb.int.toradex.com>
Date:   Mon, 13 Mar 2023 18:49:50 +0100
From:   Francesco Dolcini <francesco@...cini.it>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Francesco Dolcini <francesco@...cini.it>,
        linux-gpio@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
        linux-kernel@...r.kernel.org,
        Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v3 2/2] gpio: fxl6408: add I2C GPIO expander driver

On Mon, Mar 13, 2023 at 07:35:20PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 13, 2023 at 7:09 PM Francesco Dolcini <francesco@...cini.it> wrote:
> >
> > From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> >
> > Add minimal driver for Fairchild FXL6408 8-bit I2C-controlled GPIO expander
> > using the generic regmap based GPIO driver (GPIO_REGMAP).
> >
> > The driver implements setting the GPIO direction, reading inputs
> > and writing outputs.
> >
> > In addition to that the FXL6408 has the following functionalities:
> > - allows to monitor input ports for data transitions with an interrupt pin
> > - all inputs can be configured with pull-up or pull-down resistors
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Thanks for the review, appreciated.

> > +#include <linux/err.h>
> > +#include <linux/gpio/regmap.h>
> > +#include <linux/kernel.h>
> > +#include <linux/i2c.h>
> 
> Seems unordered?

Whoops :-/

Bartosz: if you or others have additional comments I'll change this for
sure, if not up to you - please let me know.

Francesco