linux-kernel - Re: [PATCH] ptp: ines: drop of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZA9w2T78IqLWk7ja@hoboy.vegasvil.org>
Date:   Mon, 13 Mar 2023 11:52:09 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ptp: ines: drop of_match_ptr for ID table

On Mon, Mar 13, 2023 at 05:28:43PM +0100, Simon Horman wrote:
> On Sun, Mar 12, 2023 at 02:26:37PM +0100, Krzysztof Kozlowski wrote:
> > The driver can match only via the DT table so the table should be always
> > used and the of_match_ptr does not have any sense (this also allows ACPI
> > matching via PRP0001, even though it might not be relevant here).  This
> > also fixes !CONFIG_OF error:
> > 
> >   drivers/ptp/ptp_ines.c:783:34: error: ‘ines_ptp_ctrl_of_match’ defined but not used [-Werror=unused-const-variable=]
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>

Acked-by: Richard Cochran <richardcochran@...il.com>