linux-kernel - Re: [PATCH v5] scsi: ufs: core: Add trace event for MCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2023 14:09:27 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Ziqi Chen <quic_ziqichen@...cinc.com>, quic_asutoshd@...cinc.com,
        quic_cang@...cinc.com, quic_nguyenb@...cinc.com, mani@...nel.org,
        stanley.chu@...iatek.com, adrian.hunter@...el.com,
        beanhuo@...ron.com, avri.altman@....com, junwoo80.lee@...sung.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:TRACING" <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] scsi: ufs: core: Add trace event for MCQ

On 3/13/23 02:16, Ziqi Chen wrote:
> Added a new trace event to record MCQ relevant information
> for each request in MCQ mode, include hardware queue ID,
> SQ tail slot, CQ head slot and CQ tail slot.

Added a new trace event ... -> Add the MCQ information in the existing 
trace event ...

 From Documentation/process/submitting-patches.rst: "Describe your 
changes in imperative mood, e.g. "make xyzzy do frotz"".

> Changes to v1:
> - Adjust the order of fileds to keep them aligned.
                         ^^^^^^
                         fields?

> -	u32 intr, doorbell;
> +	u32 doorbell = 0, hwq_id = 0;
> +	u32 intr;

Since hwq_id can be assigned the value -1, shouldn't its type be changed 
from u32 into int, int16_t or int32_t?

> +	struct ufs_hw_queue *hwq = NULL;

Is this pointer only used inside one branch of the if-statement below? 
If so, can it be moved under "if (is_mcq_enabled(hba)) {"?

> +		"%s: %s: tag: %u, DB: 0x%x, size: %d, IS: %u, LBA: %llu, opcode: 0x%x (%s), group_id: 0x%x, hqid: %d",

Consider changing "hqid" into "hwq_id" to make the trace information 
easier to understand.

Thanks,

Bart.