[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b43463d7-032a-93be-889f-4bb6a2a7377a@linaro.org>
Date: Mon, 13 Mar 2023 07:42:52 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: zhuyinbo <zhuyinbo@...ngson.cn>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Jianmin Lv <lvjianmin@...ngson.cn>, wanghongliang@...ngson.cn,
Liu Peibao <liupeibao@...ngson.cn>,
loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v1 1/2] dt-bindings: spi: add loongson spi
On 13/03/2023 03:09, zhuyinbo wrote:
>
> 在 2023/3/9 下午3:22, zhuyinbo 写道:
>>
>> 在 2023/3/9 下午2:23, Krzysztof Kozlowski 写道:
>>> On 09/03/2023 03:08, zhuyinbo wrote:
>>>> 在 2023/3/8 下午7:30, Krzysztof Kozlowski 写道:
>>>>> On 08/03/2023 03:59, Yinbo Zhu wrote:
>>>>>> Add the Loongson platform spi binding with DT schema format using
>>>>>> json-schema.
>>>>>>
>>>>>> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
>>>>>> ---
>>>>>> .../bindings/spi/loongson,ls-spi.yaml | 47
>>>>>> +++++++++++++++++++
>>>>>> MAINTAINERS | 6 +++
>>>>>> 2 files changed, 53 insertions(+)
>>>>>> create mode 100644
>>>>>> Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
>>>>> Filename matching the compatible.
>>>> loongson,ls-spi.yaml is for ls2k-spi and ls7a-spi, I will add following
>>>> desription:
>>>>
>>>>
>>>> properties:
>>>> compatible:
>>>> enum:
>>>> - loongson,ls2k-spi
>>>> - loongson,ls7a-spi
>>> OK then.
>>
>> I was to explain why that yaml was name as "loongson,ls-spi.yaml"
>> rather than "loongson,ls2k-spi.yaml"
>>
>> because that need consider about yaml filename to match
>> "loongson,ls2k-spi" and "loongson,ls7a-spi".
>>
>>>
>>>>>> diff --git
>>>>>> a/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
>>>>>> b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
>>>>>> new file mode 100644
>>>>>> index 000000000000..8a13a96b3818
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
>>>>>> @@ -0,0 +1,47 @@
>>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>>>> +
>>>>>> +%YAML 1.2
>>>>>> +---
>>>>>> +$id: "http://devicetree.org/schemas/spi/loongson,ls-spi.yaml#"
>>>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>>>> Drop the quotes. What was the base of your code here?
>>>> okay, I will drop the quotes. and I don't got it about the code
>>>> base
>>>> that you said.
>>>>
>>>> you meaning is advice me add a line as follows ?
>>> I meant, from which other file did you copy it?
>> okay, but I maybe forgot it, I should be refer other spi yaml file.
>>>
>>>>>> +
>>>>>> + clock-names:
>>>>>> + const: boot
>>>>> Drop clock-names, not needed for single entry.
>>>> if drop the clock-names entry, the yaml file will compile fail.
>>> Obviously you have to also drop it from DTS and driver...
>>
>> drop clock-names should be not affect my driver, but I notice other
>> lots of arm64 platform dts
>>
>> was keep clock-names and clock in dts when use grep search "clock-names".
>>
>> [zhuyinbo@...alhost www.kernel.org]$ grep -rns "clock-names" arch/arm64/
>>
>> arch/arm64/boot/dts/sprd/sc9863a.dtsi:280: clock-names =
>> "apb_pclk";
>> arch/arm64/boot/dts/sprd/sc9863a.dtsi:305: clock-names =
>> "apb_pclk";
>> arch/arm64/boot/dts/sprd/sc9863a.dtsi:330: clock-names =
>> "apb_pclk";
>> arch/arm64/boot/dts/sprd/sc9863a.dtsi:367: clock-names =
>> "apb_pclk";
>
> so , if you think it is okay I will keep clock-names and clock in yaml
> file like other platform.
No, it's not ok.
Best regards,
Krzysztof
Powered by blists - more mailing lists