linux-kernel - Re: [PATCH bpf-next v4 2/2] selftests/bpf: use canonical ftrace path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230313183946.1a98ef01@gandalf.local.home>
Date:   Mon, 13 Mar 2023 18:39:46 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Ross Zwisler <zwisler@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ross Zwisler <zwisler@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Hao Luo <haoluo@...gle.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Jiri Olsa <jolsa@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Leon Romanovsky <leon@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
        Song Liu <song@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Yonghong Song <yhs@...com>, bpf@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org,
        "Michael S . Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH bpf-next v4 2/2] selftests/bpf: use canonical ftrace
 path

On Mon, 13 Mar 2023 14:56:28 -0600
Ross Zwisler <zwisler@...nel.org> wrote:

> From: Ross Zwisler <zwisler@...gle.com>
> 
> The canonical location for the tracefs filesystem is at
> /sys/kernel/tracing.
> 
> But, from Documentation/trace/ftrace.rst:
> 
>   Before 4.1, all ftrace tracing control files were within the debugfs
>   file system, which is typically located at /sys/kernel/debug/tracing.
>   For backward compatibility, when mounting the debugfs file system,
>   the tracefs file system will be automatically mounted at:
> 
>   /sys/kernel/debug/tracing
> 
> Many tests in the bpf selftest code still refer to this older debugfs
> path, so let's update them to avoid confusion.
> 
> Signed-off-by: Ross Zwisler <zwisler@...gle.com>
> Acked-by: Michael S. Tsirkin <mst@...hat.com>

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

> ---
>  tools/testing/selftests/bpf/get_cgroup_id_user.c    |  9 +++++++--
>  .../selftests/bpf/prog_tests/kprobe_multi_test.c    |  7 ++++++-
>  .../selftests/bpf/prog_tests/task_fd_query_tp.c     |  9 +++++++--
>  .../selftests/bpf/prog_tests/tp_attach_query.c      |  9 +++++++--
>  .../testing/selftests/bpf/prog_tests/trace_printk.c | 10 +++++++---
>  .../selftests/bpf/prog_tests/trace_vprintk.c        | 10 +++++++---
>  .../selftests/bpf/progs/test_stacktrace_map.c       |  2 +-
>  tools/testing/selftests/bpf/progs/test_tracepoint.c |  2 +-
>  tools/testing/selftests/bpf/test_ftrace.sh          |  7 ++++++-
>  tools/testing/selftests/bpf/test_tunnel.sh          | 13 +++++++++----
>  tools/testing/selftests/bpf/trace_helpers.c         |  8 ++++++--
>  11 files changed, 64 insertions(+), 22 deletions(-)