linux-kernel - Re: [PATCH] gpio: mxc: use dynamic allocation of base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dad21ef9-a0ba-dbe0-cc4d-3127417e43b6@csgroup.eu>
Date:   Mon, 13 Mar 2023 22:43:46 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Arnd Bergmann <arnd@...db.de>
CC:     Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] gpio: mxc: use dynamic allocation of base



Le 07/03/2023 à 00:07, Linus Walleij a écrit :
> On Mon, Mar 6, 2023 at 11:03 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>> On Sun, Feb 26, 2023 at 9:53 PM Dario Binacchi
>> <dario.binacchi@...rulasolutions.com> wrote:
>>>
>>> Since commit 502df79b860563d7 ("gpiolib: Warn on drivers still using static
>>> gpiobase allocation"), one or more warnings are printed during boot on
>>> systems where static allocation of GPIO base is used:
>>>
>>> [    1.611480] gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation.
>>> [    1.622893] gpio gpiochip1: Static allocation of GPIO base is deprecated, use dynamic allocation.
>>> [    1.633272] gpio gpiochip2: Static allocation of GPIO base is deprecated, use dynamic allocation.
>>> [    1.643388] gpio gpiochip3: Static allocation of GPIO base is deprecated, use dynamic allocation.
>>> [    1.653474] gpio gpiochip4: Static allocation of GPIO base is deprecated, use dynamic allocation.
> (...)
>> Linus,
>>
>> I'm afraid we'll need to do something about this warning, because
>> we're getting the same patch for like 4th time already...
> 
> OK what about reverting
> commit 502df79b860563d79143be7a1453c2b3224cd836
> "gpiolib: Warn on drivers still using static gpiobase allocation"
> 
> Until we have less drivers with static allocations?
> 
> In a way it is good that it is fixed, but it's not good if you get
> snowed under by patches and discussions about this.
> 

Well, I have no strong opinion about that, as far as I remember that's 
more discussion with Arnd that made me think it was the way to go.

The Documentation has been saying since 2015 that the sysfs ABI is 
obsoleted and will be removed after 2020. So are static allocations 
required at all still ?

By the way, there are several other places in the kernel that have had 
such warnings for years without making any problem, at least that 
reminds people that something needs to be done.

Christophe