linux-kernel - Re: [PATCHv1 04/11] power: supply: generic-adc-battery: fix unit scaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local>
Date:   Tue, 14 Mar 2023 00:17:19 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Matti Vaittinen <mazziesaccount@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCHv1 04/11] power: supply: generic-adc-battery: fix unit
 scaling

Hi,

On Fri, Mar 10, 2023 at 09:23:06AM +0100, Linus Walleij wrote:
> On Thu, Mar 9, 2023 at 11:50 PM Sebastian Reichel <sre@...nel.org> wrote:
> 
> > power-supply properties are reported in µV, µA and µW.
> > The IIO API provides mV, mA, mW, so the values need to
> > be multiplied by 1000.
> >
> > Signed-off-by: Sebastian Reichel <sre@...nel.org>
> 
> Fixes: tag?
> Cc: stable@...r.kernel.org
> 
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> This code can not have seen much testing.

There is no mainline board using this driver and I think there
never was one. I did add a Fixes tag now, but its probably not worth
any backporting trouble considering it has no users.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)