linux-kernel - Re: [PATCH] usb: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2023 08:40:01 +0100
From:   Richard Leitner <richard.leitner@...ux.dev>
To:     Rob Herring <robh@...nel.org>
Cc:     Peter Chen <peter.chen@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Minas Harutyunyan <hminas@...opsys.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Richard Leitner <richard.leitner@...data.com>,
        devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: Use of_property_read_bool() for boolean properties

On Fri, Mar 10, 2023 at 08:47:28AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c |  6 +++---
>  drivers/usb/chipidea/core.c        |  2 +-
>  drivers/usb/dwc2/params.c          |  3 +--
>  drivers/usb/host/ehci-ppc-of.c     |  6 +++---
>  drivers/usb/host/fsl-mph-dr-of.c   |  7 ++-----
>  drivers/usb/misc/usb251xb.c        | 33 ++++++++++++++----------------
>  6 files changed, 25 insertions(+), 32 deletions(-)

Thanks for the patch. Please feel free to add

Reviewed-by: Richard Leitner <richard.leitner@...data.com>

for the usb251xb changes.

regards;rl