linux-kernel - Re: [PATCH] hwspinlock: omap: drop of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c27d8dd-8468-ff6d-a015-b4017b82bc72@linux.alibaba.com>
Date:   Mon, 13 Mar 2023 09:25:30 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <andersson@...nel.org>,
        linux-omap@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwspinlock: omap: drop of_match_ptr for ID table



On 3/11/2023 7:14 PM, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
> 
>    drivers/hwspinlock/omap_hwspinlock.c:164:34: error: ‘omap_hwspinlock_of_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   drivers/hwspinlock/omap_hwspinlock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c
> index 1fb3a2550e29..dfe82952671b 100644
> --- a/drivers/hwspinlock/omap_hwspinlock.c
> +++ b/drivers/hwspinlock/omap_hwspinlock.c
> @@ -174,7 +174,7 @@ static struct platform_driver omap_hwspinlock_driver = {
>   	.remove		= omap_hwspinlock_remove,
>   	.driver		= {
>   		.name	= "omap_hwspinlock",
> -		.of_match_table = of_match_ptr(omap_hwspinlock_of_match),
> +		.of_match_table = omap_hwspinlock_of_match,
>   	},
>   };
>