linux-kernel - Re: [PATCH 5/8] arm64: dts: qcom: msm8998-oneplus-cheeseburger: revert "fix backlight pin function"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2023 09:50:30 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Douglas Anderson <dianders@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        "Joseph S. Barrera III" <joebar@...omium.org>,
        Gustave Monce <gustave.monce@...look.com>,
        Vinod Koul <vkoul@...nel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] arm64: dts: qcom: msm8998-oneplus-cheeseburger:
 revert "fix backlight pin function"



On 12.03.2023 19:36, Krzysztof Kozlowski wrote:
> This reverts commit 46546f28825cf3a5ef6873b9cf947cd85c8a7258 because it
> mistakenly took PMIC pinctrl/GPIO as TLMM.  The TLMM pinctrl uses "gpio"
> function, but PMIC uses "normal", so original code was correct:
> 
>   msm8998-oneplus-cheeseburger.dtb: pmic@2: gpio@...0:button-backlight-state: 'oneOf' conditional failed, one must be fixed:
>     'gpio' is not one of ['normal', 'paired', 'func1', 'func2', 'dtest1', 'dtest2', 'dtest3', 'dtest4', 'func3', 'func4']
> 
> Fixes: 46546f28825c ("arm64: dts: qcom: msm8998-oneplus-cheeseburger: fix backlight pin function")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Eh, embarrassing. I would say to myself - use dtbs_check on patches, but
> I think that time there were too many errors coming from Qualcomm
> pinctrl bindings.
It's good that we have schema at all though.. It helps a lot!

> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> index d36b36af49d0..fac8b3510cd3 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> @@ -34,7 +34,7 @@ led-keypad-backlight {
>  &pmi8998_gpios {
>  	button_backlight_default: button-backlight-state {
>  		pins = "gpio5";
> -		function = "gpio";
> +		function = "normal";
>  		bias-pull-down;
>  		qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
>  	};