linux-kernel - Re: [PATCH 1/2] interconnect: qcom: rpm: fix msm8996 interconnect registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZA7o3zTcFQgTYrZ4@hovoldconsulting.com>
Date:   Mon, 13 Mar 2023 10:11:59 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Georgi Djakov <djakov@...nel.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Georgi Djakov <djakov@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Yassine Oudjana <y.oudjana@...tonmail.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] interconnect: qcom: rpm: fix msm8996 interconnect
 registration

On Mon, Mar 13, 2023 at 09:57:46AM +0100, Konrad Dybcio wrote:
> On 13.03.2023 09:49, Johan Hovold wrote:
> > A recent commit broke interconnect provider registration for the msm8996
> > platform by accidentally removing a conditional when adding the missing
> > clock disable in the power-domain lookup error path.
> > 
> > Fixes: b6edcc7570b2 ("interconnect: qcom: rpm: fix probe PM domain error handling")
> The hash seems to be different:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc.git/commit/?h=icc-next&id=9038710161f0f028e36ef383fca59080f48420ee

Bah, thanks for catching that.

Georgi, can you change this to:

Fixes: a8f1b7ca53c2 ("interconnect: qcom: rpm: fix probe PM domain error handling")

unless you decide to fold this fixup in?

> > Reported-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > Link: https://lore.kernel.org/r/641d04a3-9236-fe76-a20f-11466a01460e@wanadoo.fr
> > Cc: stable@...r.kernel.org      # 5.17
> > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>

Johan