linux-kernel - Re: [PATCH] pinctrl: s32cc: fix !CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYQOb8dDfyYspLE974k97ZsUH+YKk_AQJbjCpVJXP5txQ@mail.gmail.com>
Date:   Mon, 13 Mar 2023 11:20:05 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Chester Lin <clin@...e.com>, Phu Luu An <phu.luuan@....com>,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@....nxp.com>,
        Stefan-Gabriel Mirea <stefan-gabriel.mirea@....com>,
        Andrei Stefanescu <andrei.stefanescu@....com>,
        Arnd Bergmann <arnd@...db.de>,
        NXP S32 Linux Team <s32@....com>,
        Matthew Nunez <matthew.nunez@....com>,
        Radu Pirea <radu-nicolae.pirea@....com>,
        Larisa Grigore <larisa.grigore@....com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: s32cc: fix !CONFIG_PM_SLEEP build error

On Fri, Mar 10, 2023 at 3:02 PM Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> The declaration of s32_pinctrl_suspend/s32_pinctrl_resume is hidden
> in an #ifdef, causing a compilation failure when CONFIG_PM_SLEEP is
> disabled:
>
> drivers/pinctrl/nxp/pinctrl-s32g2.c:754:38: error: 's32_pinctrl_suspend' undeclared here (not in a function); did you mean 's32_pinctrl_probe'?
> drivers/pinctrl/nxp/pinctrl-s32g2.c:754:9: note: in expansion of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS'
>   754 |         SET_LATE_SYSTEM_SLEEP_PM_OPS(s32_pinctrl_suspend,
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Remove the bogus #ifdef and __maybe_unused annation on the global
> functions, and instead use the proper LATE_SYSTEM_SLEEP_PM_OPS()
> macro to pick set the function pointer.
>
> As the function definition is still in the #ifdef block, this leads
> to the correct code in all configurations.
>
> Fixes: fd84aaa8173d ("pinctrl: add NXP S32 SoC family support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Patch applied.

Yours,
Linus Walleij