linux-kernel - Re: [PATCH v4 3/8] crypto: ccp: Move some PSP mailbox bit definitions into common header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e88ca279-d8dd-b371-88f0-c6c9c79ab047@linux.intel.com>
Date:   Mon, 13 Mar 2023 12:30:01 +0200
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Mario Limonciello <mario.limonciello@....com>,
        Jan Dąbroś <jsd@...ihalf.com>,
        Grzegorz Bernacki <gjb@...ihalf.com>, Rijo-john.Thomas@....com,
        Thomas.Lendacky@....com, herbert@...dor.apana.org.au,
        John Allen <john.allen@....com>,
        Brijesh Singh <brijesh.singh@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Felix.Held@....com, "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH v4 3/8] crypto: ccp: Move some PSP mailbox bit definitions
 into common header

On 3/10/23 23:19, Mario Limonciello wrote:
> Some of the bits and fields used for mailboxes communicating with the
> PSP are common across all mailbox implementations (SEV, TEE, etc).
> 
> Move these bits into the common `linux/psp.h` so they don't need to
> be re-defined for each implementation.
> 
> Acked-by: Rijo Thomas <Rijo-john.Thomas@....com>
> Acked-by: Tom Lendacky <thomas.lendacky@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> v3->v4:
>   * Pick up tags
> v2->v3:
>   * Pick up tags
> v1->v2:
>   * Update comment to indicate it's PSP response not PSP ready
> ---
>   drivers/crypto/ccp/psp-dev.h               |  3 ---
>   drivers/crypto/ccp/sev-dev.c               | 15 +++++++--------
>   drivers/crypto/ccp/sev-dev.h               |  2 +-
>   drivers/crypto/ccp/tee-dev.c               | 15 ++++++++-------
>   drivers/i2c/busses/i2c-designware-amdpsp.c | 16 +++++-----------
>   include/linux/psp.h                        | 12 ++++++++++++
>   6 files changed, 33 insertions(+), 30 deletions(-)
> 
For the i2c-designware part:

Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>