linux-kernel - Re: [PATCH] PM / devfreq: exynos: Use of_property_present() for testing DT property presence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2023 19:39:14 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Rob Herring <robh@...nel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>
Cc:     devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / devfreq: exynos: Use of_property_present() for
 testing DT property presence

On 23. 3. 10. 23:47, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/devfreq/exynos-bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 027e8f336acc..d341876e7b62 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -432,7 +432,7 @@ static int exynos_bus_probe(struct platform_device *pdev)
>  		goto err;
>  
>  	/* Create child platform device for the interconnect provider */
> -	if (of_get_property(dev->of_node, "#interconnect-cells", NULL)) {
> +	if (of_property_present(dev->of_node, "#interconnect-cells")) {
>  		bus->icc_pdev = platform_device_register_data(
>  						dev, "exynos-generic-icc",
>  						PLATFORM_DEVID_AUTO, NULL, 0);

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi