linux-kernel - Re: [PATCH v3 1/2] drivers: rtc: add max313xx series rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <630c70a9-f82e-fe3d-324a-041cde8f5deb@alliedtelesis.co.nz>
Date:   Mon, 13 Mar 2023 02:30:09 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     "Tilki, Ibrahim" <Ibrahim.Tilki@...log.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@...log.com>
Subject: Re: [PATCH v3 1/2] drivers: rtc: add max313xx series rtc driver


On 13/03/23 15:20, Alexandre Belloni wrote:
> Hello,
>
> On 13/03/2023 02:15:26+0000, Chris Packham wrote:
>> Hi Ibrahim,
>>
>> On 18/02/23 04:17, Tilki, Ibrahim wrote:
>>>> Hi Ibrahim,
>>>>
>>>> On 9/11/22 01:22, Ibrahim Tilki wrote:
>>>>> Adding support for Analog Devices MAX313XX series RTCs.
>>>>>
>>>>> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@...log.com>
>>>>> Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@...log.com>
>>>>> ---
>>>>>     drivers/rtc/Kconfig        |   11 +
>>>>>     drivers/rtc/Makefile       |    1 +
>>>>>     drivers/rtc/rtc-max313xx.c | 1070 ++++++++++++++++++++++++++++++++++++
>>>>>     3 files changed, 1082 insertions(+)
>>>>>     create mode 100644 drivers/rtc/rtc-max313xx.c
>>>> What is the current state of this work? I see there are some comments on
>>>> this v3 iteration from late last year and I couldn't find any newer
>>>> iteration on any mailing list. We've got some new hardware arriving soon
>>>> that will have the MAX31331 RTC and I'm keen to see this patch series
>>>> land. Is there anything I can do to help it along? I can't be very
>>>> specific about when I'll see the new hardware (who can these days), the
>>>> last update was "boards are due in March".
>>>>
>>>> For the maintainers on the Cc list once the dust settles how would I get
>>>> this supported in a LTS kernel (we're currently using the 5.15 series)?
>>>> Or is totally out of the question because it's not just a new device id?
>>> Hi Chris,
>>>
>>> Patch v4 is on the way, I will be sending it in a few weeks.
>>> It is hard to tell when it is going to land but I expect to be more responsive
>>> to reviews after patch v4.
>> FYI I've now got some boards with a MAX31331. I've given v3 a quick test
>> and it works for me.
>>
>> Are you also looking at a u-boot driver? If not I can port your driver
>> across reasonably easily.
>>
> I'm curious why would you need an RTC driver for u-boot?

Short answer is because u-boot has RTC drivers and commands to set/read 
them.

Slightly longer answer is that for our current products (most with a 
DS1340 or something close) our initial manufacturing process includes 
setting the RTC from u-boot. It's mostly a "because we've always done it 
that way" but it does have the advantage that any logs or files created 
on first boot get timestamped correctly. Yes we could set the clock from 
userland on first boot but there would be a few odd log entries from 
before the RTC was set.