linux-kernel - Re: [PATCHES] fget()-to-fdget() whack-a-mole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2023 12:52:05 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHES] fget()-to-fdget() whack-a-mole

On Fri, Mar 10, 2023 at 09:25:36PM +0000, Al Viro wrote:
> 	fget()/fget_raw() should be used when we are going to keep
> struct file reference; for temporary references fdget()/fdget_raw()
> ought to be used.  That kind of stuff keeps cropping up on a regular

Fwiw, might be worth to mention/document that explicitly anywhere.
I didn't see anything but might've missed it.

> basis, and it needs periodic pruning.
> 
> 	The current pile is in vfs.git #work.fd; individual patches
> in followups.

Reviewed-by: Christian Brauner <brauner@...nel.org>