linux-kernel - Re: [PATCH] mmc: sdhci: add static to !OF stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFqaq5ysudyqOe0dB8fm=+p_ywpXdqQr33QUCq3j+Bqnrw@mail.gmail.com>
Date:   Mon, 13 Mar 2023 13:49:17 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci: add static to !OF stub

On Sat, 11 Mar 2023 at 12:12, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> The sdhci_get_compatibility() is not used outside of the unit:
>
>   drivers/mmc/host/sdhci-pltfm.c:76:6: error: no previous prototype for ‘sdhci_get_compatibility’ [-Werror=missing-prototypes]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/mmc/host/sdhci-pltfm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index 328b132bbe57..245e56324dff 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -73,7 +73,7 @@ static void sdhci_get_compatibility(struct platform_device *pdev)
>                 host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>  }
>  #else
> -void sdhci_get_compatibility(struct platform_device *pdev) {}
> +static void sdhci_get_compatibility(struct platform_device *pdev) {}
>  #endif /* CONFIG_OF */

sdhci_get_compatibility() is using OF functions with stubs for !OF.

Perhaps a cleaner option is to drop the #ifdef CONFIG_OF completely
around sdhci_get_compatibility(), thus we can drop the stub too.

>
>  void sdhci_get_property(struct platform_device *pdev)
> --
> 2.34.1
>

Kind regards
Uffe