linux-kernel - Re: [PATCH] arm64: dts: qcom: qdu1000: Add LLCC/system-cache-controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <185de2d5-8d5d-4991-1157-f30799b5f963@quicinc.com>
Date:   Mon, 13 Mar 2023 18:26:11 +0530
From:   Komal Bajaj <quic_kbajaj@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: qdu1000: Add
 LLCC/system-cache-controller node



On 3/13/2023 2:02 PM, Konrad Dybcio wrote:
>
> On 13.03.2023 08:17, Komal Bajaj wrote:
>> Add a DT node for Last level cache (aka. system cache) controller
>> which provides control over the last level cache present on QDU1000
>> and QRU1000 SoCs.
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qdu1000.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
>> index 801f090335a3..a4816a862344 100644
>> --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
>> @@ -1321,6 +1321,16 @@ gem_noc: interconnect@...00000 {
>>   			qcom,bcm-voters = <&apps_bcm_voter>;
>>   			#interconnect-cells = <2>;
>>   		};
>> +
>> +		system-cache-controller@...00000 {
>> +			compatible = "qcom,qdu1000-llcc";
>> +			reg = <0 0x19200000 0 0xd80000>,
>> +			      <0 0x1a200000 0 0x80000>,
>> +			      <0 0x221c8128 0 0x4>;
>> +			reg-names = "llcc_base", "llcc_broadcast_base", "multi_channel_register";
> Please turn this into a vertical list, like you did with reg
>
>> +			multi-ch-bit-off = <24 2>;
> driver-specific properties generally go after the generic ones,
> so swap this one with interrupts
>
> Konrad

Thanks for your comments, will address these in the next version.

Thanks,
Komal

>> +			interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
>> +		};
>>   	};
>>   
>>   	arch_timer: timer {