linux-kernel - Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7e39919-a94f-3929-8814-ada801365dfe@kontron.de>
Date:   Mon, 13 Mar 2023 14:46:08 +0100
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Alexander Stein <alexander.stein@...tq-group.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Robin Gong <yibin.gong@....com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask

On 10.03.23 10:28, Alexander Stein wrote:
> This fixes a copy & paste error.

I would mention here, that this doesn't contain any functional changes
as BUCK1_ENMODE_MASK is equal to BUCK2_ENMODE_MASK.

> 
> Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
> Originally-from: Robin Gong <yibin.gong@....com>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> This diff is extracted from a downstream commit authored by Robin Gong.
> I'm not sure if adding Originally-from: is enough here or I do have to
> change From: as well.

I never heard of "Originally-from:". Does this tag exist? Is it
documented somewhere?

I think that your tooling (git format-patch) should add a From: tag
automatically if you correctly pick up a patch from someone else.

Other than these formal issues the change itself looks good to me.

> 
>  drivers/regulator/pca9450-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
> index c84d95b11e9c..544e741f7108 100644
> --- a/drivers/regulator/pca9450-regulator.c
> +++ b/drivers/regulator/pca9450-regulator.c
> @@ -265,7 +265,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = {
>  			.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
>  			.vsel_mask = BUCK2OUT_DVS0_MASK,
>  			.enable_reg = PCA9450_REG_BUCK2CTRL,
> -			.enable_mask = BUCK1_ENMODE_MASK,
> +			.enable_mask = BUCK2_ENMODE_MASK,
>  			.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
>  			.ramp_reg = PCA9450_REG_BUCK2CTRL,
>  			.ramp_mask = BUCK2_RAMP_MASK,
> @@ -509,7 +509,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = {
>  			.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
>  			.vsel_mask = BUCK2OUT_DVS0_MASK,
>  			.enable_reg = PCA9450_REG_BUCK2CTRL,
> -			.enable_mask = BUCK1_ENMODE_MASK,
> +			.enable_mask = BUCK2_ENMODE_MASK,
>  			.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
>  			.ramp_reg = PCA9450_REG_BUCK2CTRL,
>  			.ramp_mask = BUCK2_RAMP_MASK,