linux-kernel - Re: [PATCH v1 2/4] mm: fix error handling for map_deny_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZA8vFU8iT82vYiGZ@arm.com>
Date:   Mon, 13 Mar 2023 14:11:33 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Joey Gouly <joey.gouly@....com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, nd@....com,
        acme@...hat.com, izbyshev@...ras.ru, peterx@...hat.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH v1 2/4] mm: fix error handling for map_deny_write_exec

On Wed, Mar 08, 2023 at 07:04:21PM +0000, Joey Gouly wrote:
> Commit 4a18419f71cd ("mm/mprotect: use mmu_gather") changed 'goto out;'
> to 'break' in the loop.
> This wasn't noticed while rebasing the MDWE patches, so fix it now.
> 
> Fixes: b507808ebce2 ("mm: implement memory-deny-write-execute as a prctl")
> Reported-by: Alexey Izbyshev <izbyshev@...ras.ru>
> Link: https://lore.kernel.org/linux-arm-kernel/8408d8901e9d7ee6b78db4c6cba04b78@ispras.ru/
> Signed-off-by: Joey Gouly <joey.gouly@....com>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>

Reviewed-by: Catalin Marinas <catalin.marinas@....com>