linux-kernel - RE: [EXT] Re: [PATCH v9 3/3] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2023 16:30:34 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Neeraj sanjay kale <neeraj.sanjaykale@....com>
cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "marcel@...tmann.org" <marcel@...tmann.org>,
        "johan.hedberg@...il.com" <johan.hedberg@...il.com>,
        "luiz.dentz@...il.com" <luiz.dentz@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>,
        "hdanton@...a.com" <hdanton@...a.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "simon.horman@...igine.com" <simon.horman@...igine.com>,
        Netdev <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@....com>,
        Rohit Fule <rohit.fule@....com>,
        Sherry Sun <sherry.sun@....com>
Subject: RE: [EXT] Re: [PATCH v9 3/3] Bluetooth: NXP: Add protocol support
 for NXP Bluetooth chipsets

On Mon, 13 Mar 2023, Neeraj sanjay kale wrote:

> > 
> > Thanks, looks okay to me except this one I just noticed while preparing this
> > email:
> > 
> > > +MODULE_DESCRIPTION("NXP Bluetooth Serial driver v1.0 ");
> > 
> > I don't think version numbers belong to the module description.
> > 
> I was asked to remove the MODULE_VERSION("v1.0") line in my v2 patch, hence kept it in the description.
> https://patchwork.kernel.org/project/bluetooth/patch/20230130180504.2029440-4-neeraj.sanjaykale@nxp.com/
> 
> Please suggest me the right way to put the version string in this driver.

I think Leon meant you should just drop the version altogether (since this 
is new code).

-- 
 i.

> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > 
> > 
> > --
> >  i.
> 
> Thank you again for reviewing this patch. :D
> 
> -Neeraj
>