linux-kernel - Re: [PATCH] stress-module: stress finit_module() and delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CR5D0YM6E93X.S0PN49LMWT0U@vincent-arch>
Date:   Mon, 13 Mar 2023 16:27:53 +0100
From:   "Vincenzo Palazzo" <vincenzopalazzodev@...il.com>
To:     "Luis Chamberlain" <mcgrof@...nel.org>, <colin.i.king@...il.com>,
        <patches@...ts.linux.dev>, <linux-modules@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <pmladek@...e.com>,
        <david@...hat.com>, <petr.pavlu@...e.com>, <prarit@...hat.com>
Cc:     <christophe.leroy@...roup.eu>, <song@...nel.org>
Subject: Re: [PATCH] stress-module: stress finit_module() and
 delete_module()

Just some comments on the code that feel a little bit odd to me, 
while I was reading the code.

> +#if defined(HAVE_LINUX_MODULE_H)
> +#include <linux/module.h>
> +#else
> +UNEXPECTED
> +#endif
> +
> +#if defined(HAVE_LIBGEN_H)
> +#include <libgen.h>
> +#endif
> +
> +#ifndef MODULE_INIT_IGNORE_MODVERSIONS
> +# define MODULE_INIT_IGNORE_MODVERSIONS 1
> +#endif
> +
> +#ifndef MODULE_INIT_IGNORE_VERMAGIC
> +# define MODULE_INIT_IGNORE_VERMAGIC 2
> +#endif
looks like that the #define has an exstra space and this differ from the others 
.[c,h] files?

➜  stress-ng git:(master) ✗ git grep "#define" | wc -l
2830
➜  stress-ng git:(master) ✗ git grep "# define" | wc -l
1

Cheers!

Vincent.