linux-kernel - Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b12d1fb1-1ca6-5f9c-c8b9-97c451734923@nxp.com>
Date:   Mon, 13 Mar 2023 17:47:18 +0200
From:   Laurentiu Tudor <laurentiu.tudor@....com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Stuart Yoder <stuyoder@...il.com>,
        Roy Pledge <Roy.Pledge@....com>, Li Yang <leoyang.li@....com>,
        Horia Geantă <horia.geanta@....com>,
        Pankaj Gupta <pankaj.gupta@....com>,
        Gaurav Jain <gaurav.jain@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Vinod Koul <vkoul@...nel.org>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Yangbo Lu <yangbo.lu@....com>,
        Diana Craciun <diana.craciun@....nxp.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Richard Cochran <richardcochran@...il.com>
Cc:     kernel@...gutronix.de, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        dmaengine@...r.kernel.org, netdev@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void



On 3/11/2023 12:41 AM, Uwe Kleine-König wrote:
> Hello,
> 
> many bus remove functions return an integer which is a historic
> misdesign that makes driver authors assume that there is some kind of
> error handling in the upper layers. This is wrong however and returning
> and error code only yields an error message.
> 
> This series improves the fsl-mc bus by changing the remove callback to
> return no value instead. As a preparation all drivers are changed to
> return zero before so that they don't trigger the error message.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (6):
>    bus: fsl-mc: Only warn once about errors on device unbind
>    bus: fsl-mc: dprc: Push down error message from fsl_mc_driver_remove()
>    bus: fsl-mc: fsl-mc-allocator: Drop if block with always wrong
>      condition
>    bus: fsl-mc: fsl-mc-allocator: Improve error reporting
>    soc: fsl: dpio: Suppress duplicated error reporting on device remove
>    bus: fsl-mc: Make remove function return void
> 

Thanks for the series, Uwe. Did a quick boot test with ACPI, so:

Reviewed-by: Laurentiu Tudor <laurentiu.tudor@....com>
Tested-by: Laurentiu Tudor <laurentiu.tudor@....com>