linux-kernel - Re: [PATCH 1/2] arm64: dts: ti: k3-j784s4-mcu-wakeup: Add device id property for mcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 08:29:22 -0500
From:   Nishanth Menon <nm@...com>
To:     Siddharth Vadapalli <s-vadapalli@...com>,
        Jayesh Choudhary <j-choudhary@...com>
CC:     <vigneshr@...com>, <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski@...aro.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <srk@...com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j784s4-mcu-wakeup: Add device id
 property for mcu_navss

On 16:10-20230314, Siddharth Vadapalli wrote:
> The "ti,sci-dev-id" property used to indicate the Device ID is missing
> for mcu_navss device-tree node. Add it.
> 
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> index 93952af618f6..52311da15579 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> @@ -212,6 +212,8 @@ mcu_navss: bus@...80000{
>  		dma-coherent;
>  		dma-ranges;
>  
> +		ti,sci-dev-id = <323>;
> +
>  		mcu_ringacc: ringacc@...00000 {
>  			compatible = "ti,am654-navss-ringacc";
>  			reg = <0x00 0x2b800000 0x00 0x400000>,
> -- 
> 2.25.1
> 

Looks like
https://lore.kernel.org/all/20230313104721.407071-2-j-choudhary@ti.com/
is another part of the Fixup?

Why not squash the two as a missing ti,sci-dev-id for j784s4?


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D