linux-kernel - Re: [PATCH v3] vdso: Improve cmd_vdso_check to check all dynamic relocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzzjo416.fsf@mpe.ellerman.id.au>
Date:   Wed, 15 Mar 2023 00:28:53 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Fangrui Song <maskray@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-csky@...r.kernel.org, linux-mips@...r.kernel.org,
        loongarch@...ts.linux.dev, linux-riscv@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org,
        Fangrui Song <maskray@...gle.com>
Subject: Re: [PATCH v3] vdso: Improve cmd_vdso_check to check all dynamic
 relocations

Fangrui Song <maskray@...gle.com> writes:
> The actual intention is that no dynamic relocation exists. However, some
> GNU ld ports produce unneeded R_*_NONE. (If a port fails to determine
> the exact .rel[a].dyn size, the trailing zeros become R_*_NONE
> relocations. E.g. ld's powerpc port recently fixed
> https://sourceware.org/bugzilla/show_bug.cgi?id=29540) R_*_NONE are
> generally no-op in the dynamic loaders. So just ignore them.
>
> With the change, we can remove ARCH_REL_TYPE_ABS. ARCH_REL_TYPE_ABS is a
> bit misnomer as ports may check RELAVETIVE/GLOB_DAT/JUMP_SLOT which are
> not called "absolute relocations". (The patch is motivated by the arm64
> port missing R_AARCH64_RELATIVE.)
>
> Signed-off-by: Fangrui Song <maskray@...gle.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>
> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com> # for vDSO, aarch64
> Tested-by: Vincenzo Frascino <vincenzo.frascino@....com> # for aarch64
> ---
> Changes from v2:
> * rebase
>
> Changes from v3:
> * Add a comment before `include $(srctree)/lib/vdso/Makefile` in every touched arch Makefile
> ---
>  arch/arm/vdso/Makefile            |  4 +---
>  arch/arm64/kernel/vdso/Makefile   |  4 +---
>  arch/arm64/kernel/vdso32/Makefile |  3 ---
>  arch/csky/kernel/vdso/Makefile    |  4 +---
>  arch/loongarch/vdso/Makefile      |  4 +---
>  arch/mips/vdso/Makefile           |  4 +---
>  arch/powerpc/kernel/vdso/Makefile |  2 +-

Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)

cheers