linux-kernel - Re: [PATCH -next 1/2] drm/arm/malidp: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZBB6YmrrNnufgpIh@e110455-lin.cambridge.arm.com>
Date:   Tue, 14 Mar 2023 13:45:06 +0000
From:   Liviu Dudau <liviu.dudau@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     airlied@...il.com, daniel@...ll.ch, brian.starkey@....com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/2] drm/arm/malidp: Use
 devm_platform_get_and_ioremap_resource()

On Tue, Mar 14, 2023 at 04:02:31PM +0800, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Since 'struct platform_device *pdev = to_platform_device(dev)',
> 'pdev->dev' is equivalent to 'dev'.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Acked-by: Liviu Dudau <liviu.dudau@....com>

Thanks for the cleanup! I will pull this patch and the hdlcd one into
drm-misc-next by the end of the week.

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/malidp_drv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index cf040e2e9efe..e220bfc85b2e 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -724,8 +724,7 @@ static int malidp_bind(struct device *dev)
>  	hwdev->hw = (struct malidp_hw *)of_device_get_match_data(dev);
>  	malidp->dev = hwdev;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	hwdev->regs = devm_ioremap_resource(dev, res);
> +	hwdev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(hwdev->regs))
>  		return PTR_ERR(hwdev->regs);
>  
> -- 
> 2.20.1.7.g153144c
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯