linux-kernel - Re: [PATCH v4 07/10] drm/msm/dsi: Remove custom DSI config handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 15:04:15 +0100
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     Rob Clark <robdclark@...il.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Krishna Manikandan <quic_mkrishn@...cinc.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh@...nel.org>, linux-arm-msm@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 07/10] drm/msm/dsi: Remove custom DSI config handling

On 2023-03-14 14:44:06, Konrad Dybcio wrote:
> 
> 
> On 14.03.2023 14:05, Marijn Suijten wrote:
> > On 2023-03-14 13:13:45, Konrad Dybcio wrote:
> >> Now that the only user is handled by common code, remove the option to
> >> specify custom handlers through match data.
> >>
> >> This is effectively a revert of commit:
> >> 5ae15e76271 ("drm/msm/dsi: Allow to specify dsi config as pdata")
> >>
> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> >> Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> >> ---
> [...]
> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> >> index 8772a3631ac1..91bdaf50bb1a 100644
> >> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> >> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> >> @@ -65,8 +65,5 @@ struct msm_dsi_cfg_handler {
> >>  
> >>  const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor);
> >>  
> >> -/* Non autodetect configs */
> >> -extern const struct msm_dsi_cfg_handler qcm2290_dsi_cfg_handler;
> >> -
> > 
> > Probably the wrong `fixup!` commit: this should have been part of patch
> > 6 where the struct is removed, not patch 7 (this patch).
> Yeah, that's most likely what happened.. Does that warrant another resend?

For proper cleanliness it should have been... but maybe Dmitry can patch
this up while applying?  In that case, at least have my:

Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>