linux-kernel - Re: [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3e49808-368d-f92a-b710-6d359fc6b7c2@linaro.org>
Date:   Tue, 14 Mar 2023 15:08:57 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Yong Wu (吴勇) <Yong.Wu@...iatek.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Youlin Pei (裴友林) 
        <youlin.pei@...iatek.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Jianjiao Zeng (曾健姣) 
        <Jianjiao.Zeng@...iatek.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "joro@...tes.org" <joro@...tes.org>,
        Chengci Xu (许承赐) 
        <Chengci.Xu@...iatek.com>,
        YF Wang (王云飞) <YF.Wang@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        Mingyuan Ma (马鸣远) 
        <Mingyuan.Ma@...iatek.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "will@...nel.org" <will@...nel.org>
Subject: Re: [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM
 & INFRA IOMMU

On 14/03/2023 11:14, Yong Wu (吴勇) wrote:
> On Tue, 2023-03-14 at 07:46 +0100, Krzysztof Kozlowski wrote:
>> On 14/03/2023 03:41, Yong Wu (吴勇) wrote:
>>> Hi Krzysztof,
>>>
>>> Thanks very much for your help review.
>>>
>>> On Wed, 2023-03-08 at 11:35 +0100, Krzysztof Kozlowski wrote:
>>>> On 07/03/2023 09:05, Yong Wu wrote:
>>>>> From: "Chengci.Xu" <chengci.xu@...iatek.com>
>>>>>
>>>>> Add descriptions for mt8188 IOMMU which also use ARM Short-
>>>>> Descriptor
>>>>> translation table format.
>>>>>
>>>>> In mt8188, there are two smi-common HW and IOMMU, one is for
>>>>> vdo(video
>>>>> output), the other is for vpp(video processing pipe). They
>>>>> connects
>>>>> with different smi-larbs, then some setting(larbid_remap) is
>>>>> different.
>>>>> Differentiate them with the compatible string.
>>>>>
>>>>> Something like this:
>>>>>
>>>>>   IOMMU(VDO)          IOMMU(VPP)
>>>>>       |                   |
>>>>> SMI_COMMON_VDO      SMI_COMMON_VPP
>>>>>
>>>>> ---------------     ----------------
>>>>>   |     |    ...      |     |    ...
>>>>> larb0 larb2  ...    larb1 larb3  ...
>>>>>
>>>>> We also have an IOMMU that is for infra master like PCIe.
>>>>> And infra master don't have the larb and ports.
>>>>>
>>>>> Signed-off-by: Chengci.Xu <chengci.xu@...iatek.com>
>>>>> Reviewed-by: Yong Wu <yong.wu@...iatek.com>
>>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>>
>>>> Indeed, I missed broken checkpatch/DCO chain.
>>>
>>> Just confirm what this means.
>>>
>>> Do you mean MAINTAINERS need to be updated since we add a prefix
>>> "mediatek," for the header file?
>>
>> No it means, run checkpatch.
> 
> 
> "WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
> MAINTAINERS need updating?"
>   
>  This is the only warning when I run checkpatch. I will update the
> MAINTAINERS in next version. Please tell me if I missed other parts.

Hm, I guess you are right. Your Signed-off-by is missing.

Best regards,
Krzysztof