linux-kernel - Re: [RESEND v5 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <915c9eebf8412fc092686626ce02e45a5d0f7841.camel@mediatek.com>
Date:   Mon, 13 Mar 2023 07:19:11 +0000
From:   Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>
To:     Rex-BC Chen (陳柏辰) 
        <Rex-BC.Chen@...iatek.com>, "robh@...nel.org" <robh@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "pavel@....cz" <pavel@....cz>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        CK Hu (胡俊光) <ck.hu@...iatek.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [RESEND v5 3/3] dt-bindings: mediatek: add ethdr definition for
 mt8195


On Wed, 2022-06-08 at 23:40 +0800, Rex-BC Chen wrote:
> On Wed, 2022-06-08 at 21:45 +0800, Rob Herring wrote:
> > On Wed, 08 Jun 2022 12:38:52 +0800, Bo-Chen Chen wrote:
> > > From: "Nancy.Lin" <nancy.lin@...iatek.com>
> > > 
> > > Add vdosys1 ETHDR definition.
> > > 
> > > Signed-off-by: Nancy.Lin <nancy.lin@...iatek.com>
> > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@...iatek.com>
> > > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> > > Reviewed-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@...labora.com>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > > Tested-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@...labora.com>
> > > ---
> > >  .../display/mediatek/mediatek,ethdr.yaml      | 188
> > > ++++++++++++++++++
> > >  1 file changed, 188 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr
> > > .y
> > > aml
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > Error:
> > Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e
> > xa
> > mple.dts:71.40-41 syntax error
> > FATAL ERROR: Unable to parse input tree
> > make[1]: *** [scripts/Makefile.lib:383:
> > Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e
> > xa
> > mple.dtb] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [Makefile:1404: dt_binding_check] Error 2
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.ozlabs.org/patch/
> > 
> > This check can fail if there are any dependencies. The base for a
> > patch
> > series is generally the most recent rc1.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is
> > up
> > to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit.
> > 
> 
> Hello Rob,
> 
> I am not sure why there is this error.
> But from my running result: line 71 in mediatek,ethdr.example.dts is
> "resets = <&vdosys1 MT8195_VDOSYS1_SW1_RST_B_HDR_VDO_FE0_DL_ASYNC>,"
> 
> This reset define is in previous patch of this series.
> I don't know how to avoid this.
> 
> And I also just got this:
> ./Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e
> xa
> mple.dtb: hdr-engine@...14000: mediatek,gce-client-reg:0:
> [4294967295,
> 7, 16384, 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672,
> 4096,
> 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295,
> 7,
> 45056, 4096, 4294967295, 7, 49152, 4096] is too long
>         From schema:
> ./Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y
> am
> l
> ./Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e
> xa
> mple.dtb: hdr-engine@...14000: mediatek,gce-client-reg: [[4294967295,
> 7, 16384, 4096, 4294967295, 7,
> 20480, 4096, 4294967295, 7, 28672, 4096, 4294967295, 7, 36864, 4096,
> 4294967295, 7, 40960, 4096, 4294967295, 7, 45056, 4096, 4294967295,
> 7,
> 49152, 4096]] is too short
>         From schema:
> ./Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y
> am
> l
> 
> Is there any suggestion?
> 
> BRs,
> Bo-Chen


Hi Rob,

I also got the same two messages as BO-Chen when running
dt_binding_check [1]. 

If I remove the following items/minItems/maxItems in the mediatek,gce-
client property, the two message disappear. I don't know what's wrong
with the original syntax. Do you have any suggestions for this?

-    items:
-      items:
-        - description: phandle of GCE
-        - description: GCE subsys id
-        - description: register offset
-        - description: register size
-    minItems: 7
-    maxItems: 7


[1].
Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.examp
le.dtb
/proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devicetr
ee/bindings/display/mediatek/mediatek,ethdr.example.dtb: 
hdr-engine@...14000: mediatek,gce-client-reg:0: [4294967295, 7, 16384,
4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295, 7,
45056, 4096, 4294967295, 7, 49152, 4096] is too long
        From schema:
/proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devicetr
ee/bindings/display/mediatek/mediatek,ethdr.yaml
/proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devicetr
ee/bindings/display/mediatek/mediatek,ethdr.example.dtb: 
hdr-engine@...14000: mediatek,gce-client-reg: [[4294967295, 7, 16384,
4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295, 7,
45056, 4096, 4294967295, 7, 49152, 4096]] is too short
        From schema:
/proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devicetr
ee/bindings/display/mediatek/mediatek,ethdr.yaml


Regards,
Nancy
>