linux-kernel - Re: [tip: ras/urgent] x86/mce: Make sure logged MCEs are processed after sysfs update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZBCHYHq34nlLlXKc@yaz-fattaah>
Date:   Tue, 14 Mar 2023 14:40:32 +0000
From:   Yazen Ghannam <yazen.ghannam@....com>
To:     linux-kernel@...r.kernel.org
Cc:     linux-tip-commits@...r.kernel.org,
        "Borislav Petkov (AMD)" <bp@...en8.de>,
        Tony Luck <tony.luck@...el.com>, stable@...r.kernel.org,
        x86@...nel.org
Subject: Re: [tip: ras/urgent] x86/mce: Make sure logged MCEs are processed
 after sysfs update

On Sun, Mar 12, 2023 at 08:38:33PM -0000, tip-bot2 for Yazen Ghannam wrote:
> The following commit has been merged into the ras/urgent branch of tip:
> 
> Commit-ID:     4783b9cb374af02d49740e00e2da19fd4ed6dec4
> Gitweb:        https://git.kernel.org/tip/4783b9cb374af02d49740e00e2da19fd4ed6dec4
> Author:        Yazen Ghannam <yazen.ghannam@....com>
> AuthorDate:    Wed, 01 Mar 2023 22:14:20 
> Committer:     Borislav Petkov (AMD) <bp@...en8.de>
> CommitterDate: Sun, 12 Mar 2023 21:12:21 +01:00
> 
> x86/mce: Make sure logged MCEs are processed after sysfs update
> 
> A recent change introduced a flag to queue up errors found during
> boot-time polling. These errors will be processed during late init once
> the MCE subsystem is fully set up.
> 
> A number of sysfs updates call mce_restart() which goes through a subset
> of the CPU init flow. This includes polling MCA banks and logging any
> errors found. Since the same function is used as boot-time polling,
> errors will be queued. However, the system is now past late init, so the
> errors will remain queued until another error is found and the workqueue
> is triggered.
> 
> Call mce_schedule_work() at the end of mce_restart() so that queued
> errors are processed.
> 
> Fixes: 3bff147b187d ("x86/mce: Defer processing of early errors")
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>
> Reviewed-by: Tony Luck <tony.luck@...el.com>

Thank you!

-Yazen