linux-kernel - Re: [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 15:41:52 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Jan Beulich <jbeulich@...e.com>
Cc:     Roger Pau Monné <roger.pau@...rix.com>,
        Jens Axboe <axboe@...nel.dk>, xen-devel@...ts.xenproject.org,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into
 blkback.c

On 14.03.23 15:33, Jan Beulich wrote:
> On 14.03.2023 15:27, Juergen Gross wrote:
>> V2:
>> - add const, use unsigned int for loop counters (Roger Pau Monné)
> 
> Hmm, ...
> 
>> --- a/drivers/block/xen-blkback/blkback.c
>> +++ b/drivers/block/xen-blkback/blkback.c
>> @@ -1072,7 +1072,111 @@ static void end_block_io_op(struct bio *bio)
>>   	bio_put(bio);
>>   }
>>   
>> +static void blkif_get_x86_32_req(struct blkif_request *dst,
>> +				 const struct blkif_x86_32_request *src)
>> +{
>> +	unsigned int i, n;
> 
> ... here you did, but ...
> 
>> +static void blkif_get_x86_64_req(struct blkif_request *dst,
>> +				 struct blkif_x86_64_request *src)
>> +{
>> +	int i, n;
> 
> ... what about these?

Oh, indeed. I could say Roger commented only on blkif_get_x86_32_req(), but this
would be a rather lame excuse. ;-)

I'll resend that last patch.


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)