linux-kernel - Re: [PATCH v5 3/4] media: platform: dwc: Add MIPI CSI-2 controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 15:35:15 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Sakari Ailus <sakari.ailus@....fi>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc:     Eugen Hristev <eugen.hristev@...rochip.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
        luis.oliveira@...opsys.com,
        Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v5 3/4] media: platform: dwc: Add MIPI CSI-2 controller
 driver

On Tue, Mar 14, 2023 at 04:20:09PM +0200, Sakari Ailus wrote:
> Hi Eugen,
> 
> On Fri, Dec 16, 2022 at 04:37:16PM +0200, Eugen Hristev wrote:
> > From: Luis Oliveira <Luis.Oliveira@...opsys.com>
> > 
> > Add the Synopsys MIPI CSI-2 controller driver. This
> > controller driver is divided in platform functions and core functions.
> > This way it serves as platform for future DesignWare drivers.
> > 
> > Signed-off-by: Luis Oliveira <luis.oliveira@...opsys.com>
> > Co-developed-by: Eugen Hristev <eugen.hristev@...rochip.com>
> > [eugen.hristev@...rochip.com:
> > Add format SRGGB10 to supported format list.
> > Write the data type to the correct register DATA_IDS_1.
> > Changed dev_info to dev_dbg to remove extra chatty messages
> > Avoid overwriting static array of formats]
> > Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>
> > [luis.oliveira@...opsys.com: Add MIPI CSI-2 platform data]
> > Signed-off-by: Luis Oliveira <luis.oliveira@...opsys.com>
> > [eugen.hristev@...rochip.com:
> > Add support for periph clock and phy clock
> > Fix enum_mbus function
> > Implement get_mbus_config
> > Implement media controller
> > Update to use fwnode API
> > In s_stream, first start/stop the sensor
> > remove chatty 'number of lanes' message]
> > Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>
> > [conor.dooley@...rochip.com: fix potential uninitialized variable use]
> > Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> > [eugen.hristev@...rochip.com: port to kernel 5.16, 5.17]
> > Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>
> 
> Same comment than on the 4th patch, this isn't very readable or relevant.

I'd imagine it can just be collapsed into a Co-developed-by & a signoff
as we hardly need multiple w/ the same names & companies involved each
time.
My "contribution" here (initialising some variables) doesn't warrant
inclusion IMO.

Eugen doesn't work for Microchip anymore though, and I don't know what
the plan for continuing the upstreaming of this driver is.

@Nicolas, do you have a plan here?

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)