linux-kernel - Re: [PATCH net-next v7 4/5] ip_tunnel: Preserve pointer const in ip_tunnel_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 16:42:43 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Gavin Li <gavinl@...dia.com>, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, roopa@...dia.com,
        eng.alaamohamedsoliman.am@...il.com, bigeasy@...utronix.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        gavi@...dia.com, roid@...dia.com, maord@...dia.com,
        saeedm@...dia.com
Subject: Re: [PATCH net-next v7 4/5] ip_tunnel: Preserve pointer const in
 ip_tunnel_info_opts

On Mon, Mar 13, 2023 at 07:57:23PM -0700, Eric Dumazet wrote:
> On Mon, Mar 13, 2023 at 12:51 AM Gavin Li <gavinl@...dia.com> wrote:
> >
> > Change ip_tunnel_info_opts( ) from static function to macro to cast return
> > value and preserve the const-ness of the pointer.
> >
> > Signed-off-by: Gavin Li <gavinl@...dia.com>
> > ---
> >  include/net/ip_tunnels.h | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> >
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks Gavin,

this addresses my concerns.

Reviewed-by: Simon Horman <simon.horman@...igine.com>