linux-kernel - Re: [ PATCH v4 1/6] sign-file: refactor argument parsing logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3754505.1678809728@warthog.procyon.org.uk>
Date:   Tue, 14 Mar 2023 16:02:08 +0000
From:   David Howells <dhowells@...hat.com>
To:     Shreenidhi Shedi <yesshedi@...il.com>
Cc:     dhowells@...hat.com, dwmw2@...radead.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        sshedi@...are.com
Subject: Re: [ PATCH v4 1/6] sign-file: refactor argument parsing logic

Can you please include a cover note indicating what this series is about?

> - Use getopt_long_only for parsing input args
> - Use more easy to remember command line argument names

You're also adding a bunch of new flags.  I would recommend splitting that
into a separate patch.

> +	char *hash_algo = opts.hash_algo;
> +	char *dest_name = opts.dest_name;
> +	char *private_key_name = opts.private_key_name;
> +	char *raw_sig_name = opts.raw_sig_name;
> +	char *x509_name = opts.x509_name;
> +	char *module_name = opts.module_name;

I wonder if these should now be const char *.

> @@ -292,7 +381,6 @@ int main(int argc, char **argv)
>  		exit(3);
>  	}
>  #endif
> -
>  	/* Open the module file */
>  	bm = BIO_new_file(module_name, "rb");
>  	ERR(!bm, "%s", module_name);

Please don't remove that blank line - it separates two logically distinct
parts of the program.

David