linux-kernel - Re: [PATCH 5.10 1/1] usb: musb: core: drop redundant checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04bbe1e9-8b6b-9b06-f00c-40ccda1b47ae@omp.ru>
Date:   Tue, 14 Mar 2023 20:06:34 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Danila Chernetsov <listdansp@...l.ru>, <stable@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Bin Liu <b-liu@...com>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <lvc-project@...uxtesting.org>
Subject: Re: [PATCH 5.10 1/1] usb: musb: core: drop redundant checks

On 3/14/23 8:01 PM, Danila Chernetsov wrote:

> From: Sergey Shtylyov <s.shtylyov@....ru>
> 
> commit b0ec7e55fce65f125bd1d7f02e2dc4de62abee34 upstream. 
> 
> In musb_{save|restore}_context() the expression '&musb->endpoints[i]' just
> cannot be NULL, so the checks have no sense at all -- after dropping them,
> the local variables 'hw_ep' are no longer necessary, so drop them as well.
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
> Link: https://lore.kernel.org/r/3f8f60d9-f1b5-6b2c-1222-39b156151a22@omp.ru
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Danila Chernetsov <listdansp@...l.ru>
> ---
>  drivers/usb/musb/musb_core.c | 16 ++--------------
>  1 file changed, 2 insertions(+), 14 deletions(-)

   Hum... why do you need it it 5.10.y?

[...]

MBR, Sergey