linux-kernel - [PATCH v3] HID:hid-sensor-custom: Fix buffer overrun in device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230314172834.13175-1-todd.e.brandt@intel.com>
Date:   Tue, 14 Mar 2023 10:28:34 -0700
From:   Todd Brandt <todd.e.brandt@...el.com>
To:     linux-input@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     todd.e.brandt@...ux.intel.com, todd.e.brandt@...el.com,
        srinivas.pandruvada@...ux.intel.com, jic23@...nel.org,
        jikos@...nel.org, p.jungkamp@....net
Subject: [PATCH v3] HID:hid-sensor-custom: Fix buffer overrun in device name

On some platforms there are some platform devices created with
invalid names. For example: "HID-SENSOR-INT-020b?.39.auto" instead
of "HID-SENSOR-INT-020b.39.auto"

This string include some invalid characters, hence it will fail to
properly load the driver which will handle this custom sensor. Also
it is a problem for some user space tools, which parses the device
names from ftrace and dmesg.

This is because the string, real_usage, is not NULL terminated and
printed with %s to form device name.

To address this, initialize the real_usage string with 0s.

Reported-and-tested-by: Todd Brandt <todd.e.brandt@...ux.intel.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217169
Suggested-by: Philipp Jungkamp <p.jungkamp@....net>
Signed-off-by: Philipp Jungkamp <p.jungkamp@....net>
Signed-off-by: Todd Brandt <todd.e.brandt@...el.com>
Reviewed-by: Andi Shyti <andi.shyti@...nel.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
---
 drivers/hid/hid-sensor-custom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c
index 3e3f89e01d81..d85398721659 100644
--- a/drivers/hid/hid-sensor-custom.c
+++ b/drivers/hid/hid-sensor-custom.c
@@ -940,7 +940,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
 				    struct hid_sensor_hub_device *hsdev,
 				    const struct hid_sensor_custom_match *match)
 {
-	char real_usage[HID_SENSOR_USAGE_LENGTH];
+	char real_usage[HID_SENSOR_USAGE_LENGTH] = { 0 };
 	struct platform_device *custom_pdev;
 	const char *dev_name;
 	char *c;
-- 
2.17.1