[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c45406e4-51e5-0df6-4b53-6355a56a0a34@linaro.org>
Date: Tue, 14 Mar 2023 19:49:43 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jim Liu <jim.t90615@...il.com>, JJLIU0@...oton.com,
KWLIU@...oton.com, linus.walleij@...aro.org, brgl@...ev.pl,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH v5 2/3] arm: dts: nuvoton: npcm: Add sgpio feature
On 14/03/2023 19:47, Krzysztof Kozlowski wrote:
> On 14/03/2023 10:23, Jim Liu wrote:
>> Add the SGPIO controller to the NPCM7xx devicetree
>>
>> Signed-off-by: Jim Liu <jim.t90615@...il.com>
>> ---
>> Changes for v5:
>> - remove npcm8xx node
>> Changes for v4:
>> - add npcm8xx gpio node
>> Changes for v3:
>> - modify node name
>> - modify in/out property name
>> Changes for v2:
>> - modify dts node
>> ---
>> arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 30 +++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
>> index c7b5ef15b716..7f53774a01ec 100644
>> --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
>> +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
>> @@ -330,6 +330,36 @@
>> status = "disabled";
>> };
>>
>> + gpio8: gpio@...000 {
>> + compatible = "nuvoton,npcm750-sgpio";
>> + reg = <0x101000 0x200>;
>> + clocks = <&clk NPCM7XX_CLK_APB3>;
>> + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
>> + bus-frequency = <8000000>;
>
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
Eh, wrong key shortcut. Should be:
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
Best regards,
Krzysztof
Powered by blists - more mailing lists