linux-kernel - Re: [PATCH] p54spi: convert to devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e19fd8bc-5944-409d-a4a1-3a3d53691634@app.fastmail.com>
Date:   Tue, 14 Mar 2023 22:40:26 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Christian Lamparter" <chunkeey@...glemail.com>,
        "Kalle Valo" <kvalo@...nel.org>
Cc:     "Linus Walleij" <linus.walleij@...aro.org>,
        "Bartosz Golaszewski" <brgl@...ev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        "Tony Lindgren" <tony@...mide.com>,
        "Aaro Koskinen" <aaro.koskinen@....fi>,
        "Felipe Balbi" <balbi@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Benoît Cousson <bcousson@...libre.com>,
        "Russell King" <linux@...linux.org.uk>,
        "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        "Johannes Berg" <johannes@...solutions.net>,
        linux-wireless@...r.kernel.org, Netdev <netdev@...r.kernel.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] p54spi: convert to devicetree

On Tue, Mar 14, 2023, at 20:57, Krzysztof Kozlowski wrote:
> On 14/03/2023 17:30, Arnd Bergmann wrote:
>
> Please split bindings to separate patch.
>
>>  MAINTAINERS                                   |  1 +
>>  arch/arm/boot/dts/omap2.dtsi                  |  4 ++
>>  arch/arm/boot/dts/omap2420-n8x0-common.dtsi   | 12 ++++
>
> DTS as well...

ok

>> +maintainers:
>> +  - Johannes Berg <johannes@...solutions.net>
>> +  - Christian Lamparter <chunkeey@....de>
>> +
>> +description: |
>
> You can drop '|'.

ok

>> +properties:
>> +  compatible:
>> +    enum:
>> +      - st,stlc4550
>> +      - st,stlc4560
>> +      - isil,p54spi
>> +      - cnxt,3110x
>
> Order above entries by name.

ok

>> +
>> +  power-gpios:
>
> If this is GPIO driving some power pin, then it should be
> "powerdown-gpios" (like in /bindings/gpio/gpio-consumer-common.yaml)

As far as I can tell, it's the opposite: the gpio turns the power on
in 'high' state. I could make it GPIO_ACTIVE_LOW and call it powerdown,
if you think that's better, but I don't think that is how it was
meant.

>> +examples:
>> +  - |
>> +   gpio {
>
> Align example with above |, so four spaces. Or better indent entire
> example with four spaces.

Ok, that makes it much more readable.

>> +     gpio-controller;
>> +     #gpio-cells = <1>;
>> +     #interupt-cells = <1>;
>> +   };
>
> Drop "gpio" node. It's not needed for the example.

ok.

>> +   spi {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      wifi@0 {
>> +        reg = <0>;
>> +        compatible = "st,stlc4560";
>
> compatible before reg.

ok.

       Arnd