linux-kernel - Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230314034458.GQ143566@dragon>
Date:   Tue, 14 Mar 2023 11:44:58 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Ivan Bornyakov <i.bornyakov@...rotek.ru>
Cc:     linux-imx@....com, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a
 garbage value

On Mon, Mar 06, 2023 at 04:25:26PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
> 
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
> 
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
> Signed-off-by: Ivan Bornyakov <i.bornyakov@...rotek.ru>
> Cc: stable@...r.kernel.org
> Reviewed-by: Fabio Estevam <festevam@...il.com>

Ok, picked this version up instead.