linux-kernel - Re: [PATCH v4 04/16] perf kvm: Use subtraction for comparison metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230314002656.GC2426758@leoy-yangtze.lan>
Date:   Tue, 14 Mar 2023 08:26:56 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        John Garry <john.g.garry@...cle.com>,
        James Clark <james.clark@....com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 04/16] perf kvm: Use subtraction for comparison metrics

On Mon, Mar 13, 2023 at 02:58:22PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 13, 2023 at 07:40:06PM +0800, Leo Yan escreveu:
> > Currently the metrics comparison uses greater operator (>), it returns
> > the boolean value (0 or 1).
> > 
> > This patch changes to use subtraction as comparison result, which can
> > be used by histograms sorting.  Since the subtraction result is u64
> > type, we change the function return type from int to int64_t to avoid
> > overflow.
> 
> Not building at his point in the series:

Sorry for this!

I can reproduce the building failure, will check patches compilation one
by one and send out new patch set in today's later time.

Thanks,
Leo