linux-kernel - Re: Question about the dependency on the config SOC_FSL in CPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 09:31:07 +0100
From:   Herve Codina <herve.codina@...tlin.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Li Yang <leoyang.li@....com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Mark Brown <broonie@...nel.org>,
        Qiang Zhao <qiang.zhao@....com>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: Question about the dependency on the config SOC_FSL in CPM_QMC

Hi Lukas, Mark,

On Tue, 14 Mar 2023 09:17:18 +0100
Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:

> On Tue, Mar 14, 2023 at 8:57 AM Herve Codina <herve.codina@...tlin.com> wrote:
> >
> > Hi Lukas,
> >
> > On Tue, 14 Mar 2023 08:21:50 +0100
> > Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
> >  
> > > Dear Herve,
> > >
> > > In your patch below, you added the config CPM_QMC which depends on the
> > > non-existing config SOC_FSL:
> > >
> > > https://lore.kernel.org/r/20230217145645.1768659-7-herve.codina@bootlin.com
> > >
> > > Up to my knowledge, the config SOC_FSL never existed in the mainline
> > > tree. Is this dependency really required or can the expression simply
> > > be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL?
> > >
> > > Note: This patch has now shown up in linux-next with commit
> > > 3178d58e0b97. Currently, it would not be possible to compile test this
> > > driver, as the dependency on SOC_FSL is never met.
> > >
> > >
> > > Best regards,
> > >
> > > Lukas  
> >
> > My bad :(
> >
> > The dependency must be FSL_SOC instead of SOC_FSL.  
> 
> Herve, are you going to send a quick fix to your patch or ask Mark if
> your original patch can simply be replaced with a new one with this
> change added?

I have just sent a quick fix.
  https://lore.kernel.org/linux-kernel/20230314082157.137176-1-herve.codina@bootlin.com/

Mark, it can be squashed with
  3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")

Regards
Hervé

> 
> Lukas
> 
> > I mean:
> > diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
> > index f90cfdf0c763..7268c2fbcbc1 100644
> > --- a/drivers/soc/fsl/qe/Kconfig
> > +++ b/drivers/soc/fsl/qe/Kconfig
> > @@ -47,7 +47,7 @@ config CPM_TSA
> >  config CPM_QMC
> >         tristate "CPM QMC support"
> >         depends on OF && HAS_IOMEM
> > -       depends on CPM1 || (SOC_FSL && COMPILE_TEST)
> > +       depends on CPM1 || (FSL_SOC && COMPILE_TEST)
> >         depends on CPM_TSA
> >         help
> >           Freescale CPM QUICC Multichannel Controller
> >
> >
> >
> > --
> > Hervé Codina, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com