linux-kernel - Re: [PATCH v2] rdmavt: delete unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167878596798.47051.3381152453876603271.b4-ty@kernel.org>
Date:   Tue, 14 Mar 2023 11:26:07 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Natalia Petrova <n.petrova@...tech.ru>
Cc:     Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH v2] rdmavt: delete unnecessary NULL check


On Fri, 03 Mar 2023 15:44:08 +0300, Natalia Petrova wrote:
> There is no need to check 'rdi->qp_dev' for NULL. The field 'qp_dev'
> is created in rvt_register_device() which will fail if the 'qp_dev'
> allocation fails in rvt_driver_qp_init(). Overwise this pointer
> doesn't changed and passed to rvt_qp_exit() by the next step.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> [...]

Applied, thanks!

[1/1] rdmavt: delete unnecessary NULL check
      https://git.kernel.org/rdma/rdma/c/9b3366ec12f0d7

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>