linux-kernel - Re: [PATCH -next 1/3] video: fbdev: pxa3xx-gcu: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e402daa-a9ba-59c2-92c4-f1ecd155acda@gmx.de>
Date:   Tue, 14 Mar 2023 11:48:01 +0100
From:   Helge Deller <deller@....de>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/3] video: fbdev: pxa3xx-gcu: Use
 devm_platform_get_and_ioremap_resource()

On 3/14/23 06:42, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

series applied to fbdev git tree.

Thanks!
Helge

> ---
>   drivers/video/fbdev/pxa3xx-gcu.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
> index c3cd1e1cc01b..d16729215423 100644
> --- a/drivers/video/fbdev/pxa3xx-gcu.c
> +++ b/drivers/video/fbdev/pxa3xx-gcu.c
> @@ -599,8 +599,7 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
>   	priv->misc_dev.fops	= &pxa3xx_gcu_miscdev_fops;
>
>   	/* handle IO resources */
> -	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	priv->mmio_base = devm_ioremap_resource(dev, r);
> +	priv->mmio_base = devm_platform_get_and_ioremap_resource(pdev, 0, &r);
>   	if (IS_ERR(priv->mmio_base))
>   		return PTR_ERR(priv->mmio_base);
>