linux-kernel - Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64f9d3ca-268e-71ae-4a6d-b71315a8406e@gmail.com>
Date:   Tue, 14 Mar 2023 01:07:59 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Kloudifold <cloudifold.3125@...il.com>,
        teddy.wang@...iconmotion.com, sudipm.mukherjee@...il.com,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        outreachy@...ts.linux.dev
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase

On 3/13/23 21:43, Kloudifold wrote:
> The sm750 driver had some functions named in CamelCase,
> which violates the kernel's naming convention.
> In this patch, I rename these functions to snake case,
> which is the expected style.

Hi,
please make the Subject more unique. Many patches could have this name.
Look for examples in:
https://lore.kernel.org/linux-staging/

Please use your full name consisting of a given name and a family name 
in front of your email. Or is this not possible and "Kloudifold" is both?

> This v2 patch was prompted by an error reported by the
> Linux test robot, which detected the compile error.
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/
> 
> Signed-off-by: Kloudifold <cloudifold.3125@...il.com>

The explanation what has changed needs to be below the ---
but your Signed-off-by: is not allowed to be below this ---
Look for examples of v2 in:
https://lore.kernel.org/linux-staging/

Thanks

Bye Philipp