linux-kernel - Re: [PATCH v12 1/4] serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBHtHDZQmP8f8aio@corigine.com>
Date:   Wed, 15 Mar 2023 17:06:52 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, marcel@...tmann.org,
        johan.hedberg@...il.com, luiz.dentz@...il.com,
        gregkh@...uxfoundation.org, jirislaby@...nel.org,
        alok.a.tiwari@...cle.com, hdanton@...a.com,
        ilpo.jarvinen@...ux.intel.com, leon@...nel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        linux-serial@...r.kernel.org, amitkumar.karwar@....com,
        rohit.fule@....com, sherry.sun@....com
Subject: Re: [PATCH v12 1/4] serdev: Replace all instances of ENOTSUPP with
 EOPNOTSUPP

On Wed, Mar 15, 2023 at 05:33:23PM +0530, Neeraj Sanjay Kale wrote:
> This replaces all instances of ENOTSUPP with EOPNOTSUPP since ENOTSUPP
> is not a standard error code. This will help maintain consistency in
> error codes when new serdev API's are added.
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> ---
> v11: Replace all instances of ENOTSUPP with EOPNOTSUPP. (Simon Horman)

There may be a policy or issue here, I defer to the maintainer on that.
But from my PoV this looks good.

Reviewed-by: Simon Horman <simon.horman@...igine.com>

BTW, please consider waiting 24h between patch postings to
allow review to take place.