linux-kernel - Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBHuoGrHyWBSJcoZ@ubun2204.myguest.virtualbox.org>
Date:   Wed, 15 Mar 2023 21:43:20 +0530
From:   Deepak R Varma <drv@...lo.com>
To:     Kloudifold <cloudifold.3125@...il.com>
Cc:     Alison Schofield <alison.schofield@...el.com>,
        teddy.wang@...iconmotion.com, sudipm.mukherjee@...il.com,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase

On Wed, Mar 15, 2023 at 11:35:37PM +0800, Kloudifold wrote:
> Hi Alison,
> 
> Thanks a lot for your help, so if I send my v3 patch, should it be like
> below? (Philipp said "please make the Subject more unique", but the
> Subject could be only a few permutations of very few words, I can't see
> how it could be any more unique.)
> 
> Subject: [PATCH v2] staging: sm750: Rename functions from CamelCase to snake case
> 
> sm750 driver has sm750_hw_cursor_* functions, which are named in
> camelcase. Rename them to snake case to follow the function naming
> convention.

You may want to review similar patches submitted in the past by the developers
and get hints on how it was named then. Use it to improve your understanding,
let your own thoughtfulness prevail.

https://lore.kernel.org/?q=&a=search+all+inboxes

Thanks,
Deepak.

> 
> Changes in v3:
> - Add this changelog (Philipp)
> - Move lkp tags and link to the correct location in commit log (Alison)
> - Update the commit msg (Philip)
> - Update the commit log (Bagas, Julia)
> 
> Changes in v2:
> - Use new function names in call sites (LKP)
> 
> Signed-off-by: Kloudifold <cloudifold.3125@...il.com>
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/
> ---
> git diff message
> ---
>