linux-kernel - Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3096768.uvML7RA1vL@suse>
Date:   Wed, 15 Mar 2023 17:44:47 +0100
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>
Cc:     Alison Schofield <alison.schofield@...el.com>,
        outreachy@...ts.linux.dev,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only

On mercoledì 15 marzo 2023 14:56:27 CET Khadija Kamran wrote:
> On Wed, Mar 15, 2023 at 02:13:51PM +0100, Fabio M. De Francesco wrote:
> > On mercoledì 15 marzo 2023 13:32:55 CET Khadija Kamran wrote:
> > > On Tue, Mar 14, 2023 at 04:57:47PM -0700, Alison Schofield wrote:
> > > > My guess is that this patch gets ignored because it has a lower 
version
> > > > number than a previous patch.
> > > > 
> > > > Take the feedback given here, and rev to
> > > > [PATCH v5] staging: axis-fifo: initialize timeouts in probe only
> > > > 
> > > > Be sure the Changelog, below the --- explains the journey.
> > > > 
> > > > Changes in v5:
> > > > 
> > > > Changes in v4:
> > > > 
> > > > Changes in v3:
> > > 
> > > > Changes in v2:
> > > Hey Alison!
> > 
> > Hi Khadija,
> > 
> > Please put one or two blank lines between the last message you are 
replying
> > and the new you are writing (exactly as I'm doing here between "Hey 
Alison!"
> > and "Hi Khadija").
> 
> Hey Fabio!
> 
> Sorry about that. This was pointed by Alison before and I have been
> adding spaces since then. Hopefully I am doing it right this time.
> 
You are doing right this time :-)
>
> > > Based on Nathan's feedback I am trying to recompile and send a patch
> > > without any warnings.
> > 
> > Great!
> > 
> > > As suggested by Fabio, I am running "make w=1 -jX" command to see if I
> > > get any warnings.
> > 
> > I suppose that "w=1" is a typo. The option is enabled with "W=1" (capital
> > case, Linux and all UNIX-like are case-sensitive).
> 
> Okay. I should re-run it with "W=1".
> 
> > > But it is taking a lot of time, is there any way of
> > > speeding it up?
> > 
> > What is you choice for 'X' in "-jX"?
> 
> I used "-j4".
> 
> > Did you try with the exact number of logical cores?
> > Are you building into a VM with enough logical cores?
> > If you are building into a VM, did you reserve enough RAM?
> 
> I am using Ubuntu 22.04.01 with the help of VM on VMware.
> My machine has 13GB RAM and 2 processors(4 cores each).

Therefore, you are using a Linux guest on a Linux host. This is a wise choice. 
However, you didn't say where you are running your builds...

I mean, the better things to do are the following steps:

1) Your workspace with the staging tree should stay in the host.
2) Shut down your guest in order to have all RAM and all logical processors 
available for the build.
3) Run "make -j8" in the host. Since you shutdown your guest VM you can use 
all 8 logical cores and the maximum available RAM (without the VM draining 
resources while building)
4) When the build is done, switch on your VM on VMware with at least 4 logical 
cores and 6GB of reserved RAM.
5) Mount your cloned base directory as a shared folder between host and guest.
6) In the guest, 'cd' to the shared folder and then run "make modules_install 
install" (in the guest, attention). This will install and configure the 
kernel, the modules, GRUB2 and everything else in your guest VM.
7) Reboot the VM and test your patches.

This procedure will speed up your next builds.
The fundamental point is that you don't need to partition precious resources 
while building, Do everything without running the VM and switch it on only for 
install and tests. Since you only build in the host but never install and boot 
in it, you don't risk any system's damage.

This is what I do for Kernel development purposes.

I hope it helps to answer your question about how to run fast recompilation.

Fabio  


> 
> > Please read carefully my questions above and try to understand your
> > environment and reply, so that I can help you more effectively.
> > 
> > > If this doesn't work then I have to follow the steps to reproduce in lkp
> > > mail as you said before.
> > 
> > The steps to reproduce will take your precious time and use more 
resources.
> > Again, try to respond my questions.
> > 
> > > After dealing with these warnings I will send a [PATCH v5], following
> > > your instructions above.
> > 
> > Sorry for inadvertently overlooking to warn you about to send a message to
> > Greg and ask him to drop your first 3 + 1 patches. Now you are doing good 
by
> > following what Alison suggested: send v5 and write the log of revisions
> > under
> > the three dashes (exactly how Alison explained).
> > 
> > > Kindly, let me know if I am on the wrong track.
> > > Thank you!
> > 
> > I think you are in the right track.
> > Let's try to speed up your builds because you'll need to build again your
> > kernel many, many times for future works.
> 
> Okay great! Thank you.
> 
> Regards,
> Khadija
> 
> > Thanks,
> > 
> > Fabio