linux-kernel - Re: [PATCH RESEND] leds: qcom-lpg: Release node reference before returning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230315171122.GF9667@google.com>
Date:   Wed, 15 Mar 2023 17:11:22 +0000
From:   Lee Jones <lee@...nel.org>
To:     Deepak R Varma <drv@...lo.com>
Cc:     Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_c_skakit@...cinc.com,
        bjorn.andersson@...aro.org, dianders@...omium.org,
        marijn.suijten@...ainline.org, luca@...tu.xyz,
        Saurabh Singh Sengar <ssengar@...rosoft.com>,
        Praveen Kumar <kumarpraveen@...ux.microsoft.com>
Subject: Re: [PATCH RESEND] leds: qcom-lpg: Release node reference before
 returning

On Sat, 04 Mar 2023, Deepak R Varma wrote:

> The iterator for_each_available_child_of_node() increments the refcount
> of the child node it is processing. Release such a reference when the
> loop needs to breaks due to en error during its execution.
> Issue identified using for_each_child.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@...lo.com>
> ---
> Please note:
>    - The proposed change is compile tested only. I do not have the
>      necessary hardware to perform additional testing. Please suggest if there
>      is an alternate means available to further test this change.
>    - Included authors/experts for this driver for guidance as suggested by
>      Lee Jones <lee@...nel.org> and resending the patch.
>
>
>  drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]