linux-kernel - Re: [PATCH] mm: mempool: Optimize the mempool_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d478a5d-a7af-ab9f-a04e-fc40a95bc861@gmail.com>
Date:   Wed, 15 Mar 2023 10:53:06 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Li zeming <zeming@...china.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: mempool: Optimize the mempool_create_node function

On 3/15/23 12:12, Li zeming wrote:
> The pool pointer variable gets the kzalloc_node function return value
> directly at definition time, which should be more concise.
> 
> Signed-off-by: Li zeming <zeming@...china.com>

This looks pretty useless as a change, the generated code is going to be 
the same before/after, it is also not more readable, and it is 
definitively not an optimization in the sense that optimization should 
be used as meaning: the code is more efficient after that change.
-- 
Florian